linux-kernel - Re: [patch]block cfq: select new workload if priority changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49sjy5ad81.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 10 Dec 2010 09:56:14 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Jens Axboe <jaxboe@...ionio.com>, czoccolo@...il.com
Subject: Re: [patch]block cfq: select new workload if priority changed

Shaohua Li <shaohua.li@...el.com> writes:

> If priority is changed, continue checking workload_expires and service tree
> count of previous workload is meaningless. We should always choose the workload

I'd change that first sentence to:

  If priority is changed, continuing to check workload_expires and
  service tree count of the previous workload does not make sense.

> with lowest key of new priority in such case.
>
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>

This makes sense to me.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/