linux-kernel - Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101210180400.GB12085@suse.de>
Date:	Fri, 10 Dec 2010 10:04:00 -0800
From:	Greg KH <gregkh@...e.de>
To:	Dave Jones <davej@...hat.com>, Dan Carpenter <error27@...il.com>,
	Marek Belisko <marek.belisko@...n-nandra.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs.

On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote:
> On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote:
>  > > +	file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir,
>  >                                                        ^^^^^^^
>  > > +					NULL, &ft1000fops);
>  > 
>  > Don't make this world writeable.
> 
> we should probably make checkpatch catch this.
> 
> 
> 
> 
> Exporting world writable sysfs/debugfs files is usually a bad thing.
> Warn about it.
> 
> Signed-off-by: Dave Jones <davej@...hat.com>

Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/