linux-kernel - Re: [PATCH] pci: Skip id checking if no id is passed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Dec 2010 13:06:56 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pci: Skip id checking if no id is passed

On Wed, 17 Nov 2010 12:10:40 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> 
> Will get warning when pci stub driver is built-in kenel like:
> pci-stub: invalid id string ""
> 
> So stop early if no id is passed.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> ---
>  drivers/pci/pci-stub.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> Index: linux-2.6/drivers/pci/pci-stub.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-stub.c
> +++ linux-2.6/drivers/pci/pci-stub.c
> @@ -47,6 +47,10 @@ static int __init pci_stub_init(void)
>  	if (rc)
>  		return rc;
>  
> +	/* no ids passed actually */
> +	if (ids[0] == '\0')
> +		return 0;
> +
>  	/* add ids specified in the module parameter */
>  	p = ids;
>  	while ((id = strsep(&p, ","))) {
> 

Applied to linux-next, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/