linux-kernel - Re: [PATCH v2] PCI: Disable ASPM if BIOS asks us to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101210132108.180b5114@jbarnes-desktop>
Date:	Fri, 10 Dec 2010 13:21:08 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: Disable ASPM if BIOS asks us to

On Fri, 10 Dec 2010 21:18:49 +0000
Matthew Garrett <mjg59@...f.ucam.org> wrote:

> On Fri, Dec 10, 2010 at 01:07:19PM -0800, Jesse Barnes wrote:
> > On Mon,  6 Dec 2010 14:00:56 -0500
> > Matthew Garrett <mjg@...hat.com> wrote:
> > 
> > > We currently refuse to touch the ASPM registers if the BIOS tells us that
> > > ASPM isn't supported. This can cause problems if the BIOS has (for any
> > > reason) enabled ASPM on some devices anyway. Change the code such that we
> > > explicitly clear ASPM if the FADT indicates that ASPM isn't supported,
> > > and make sure we tidy up appropriately on device removal in order to deal
> > > with the hotplug case. If ASPM is disabled because the BIOS doesn't hand
> > > over control then we won't touch the registers.
> > > 
> > > Signed-off-by: Matthew Garrett <mjg@...hat.com>
> > > ---
> > > 
> > 
> > Applied to linux-next, thanks.
> 
> Agh. It seems I sent the wrong version - there's a missing e in 
> pci_clear_aspm. Can you fix that up, or should I resend?

I'll fix it up (was just doing the build test now), thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/