linux-kernel - Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101210234253.28c5e76e@lxorguk.ukuu.org.uk>
Date:	Fri, 10 Dec 2010 23:42:53 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	ltuikov@...oo.com
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

> I think people need to know.

I think they will judge themselves from the full discussion. I'm not sure
they'll vote in your favour however.

"So to expose the obvious, hypothetically, one of the resident "linux
kernel engineers/maintainers" could've submitted AN EMPTY DRIVER that
"binds to" the UAS id, and from then on, any other improvements would
have to go through them"

Strangely that doesn't work because the community isn't full of idiots,
in fact we actively select against them because anyone who is maintaining
a driver needs to be able to deal with other people (at least other
people who wish to be constructive).

"Do you not see HOW DIFFERENT the two drivers are? Do you not see the
difference in quality, presentation, etc, etc."

I find the presentation *very* different. I'm rather worried about the
manner in which it is being presented. Your driver may be the best on the
planet - who knows - but if your response to needing to work with people
is to accuse them of being part of some giant conspiracy or make offensive
comments then that's rapidly going to outweight the quality of the code
and you'll simply run out of people to talk to.

It's actually pretty hard to get in GregKH's kill file, and I suspect by
now you are in a few others as well. So perhaps you can find someone
working with you who has people skills and can sit between you and Greg
and other maintainers and make progress ? It won't be the first time a
user interface problem has been fixed that way in the Linux world.

But basically it's really simple. When we have an existing driver we work
from it - step by step from where we are, to where we want to be. That
series of steps should tell a story so anyone reading the patch series can
understand how it unfolded.

We also have a process for dealing with people not responding, and
irritating them enough they killfile you and refuse to deal with you
isn't that process, especially when you then get yourself killfiled by
the next maintainer up as well.

When you come along late and say "I've got this great other driver", then
sorry you missed the party - you could have submitted yours earlier and
the question becomes "how do I make the existing driver at least as cool
as the one that was too late" not "how do I replace it"

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/