| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1292097745-9680-1-git-send-email-plyatov@gmail.com>
Date: Sat, 11 Dec 2010 23:02:25 +0300
From: Igor Plyatov <plyatov@...il.com>
To: sshtylyov@...sta.com
Cc: jgarzik@...ox.com, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org, geomatsi@...il.com,
nicolas.ferre@...el.com, linux@...im.org.za,
linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
christian.glindkamp@...kit.de, ryan@...ewatersys.com,
pgsellmann@...tner-elektronik.at, Igor Plyatov <plyatov@...il.com>
Subject: [PATCH] ide: at91_ide.c bugfix for high master clock
The AT91SAM9 microcontrollers with master clock higher then 105 MHz
and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This
lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and at91_ide
driver does not detect ATA device.
This patch must be applied on top of my patch for pata_at91 where the
same bug fixed.
Signed-off-by: Igor Plyatov <plyatov@...il.com>
---
drivers/ata/pata_at91.c | 2 +-
drivers/ide/at91_ide.c | 31 +++++++++++++++++++++----------
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
index 2e189be..a462405 100644
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -113,7 +113,7 @@ static void set_smc_timing(struct device *dev,
ncs_read_pulse = read_cycle - 2;
if (ncs_read_pulse > NCS_RD_PULSE_LIMIT) {
ncs_read_pulse = NCS_RD_PULSE_LIMIT;
- dev_dbg(dev, "ncs_read_pulse limited to maximal value %lu\n",
+ dev_warn(dev, "ncs_read_pulse limited to maximal value %lu\n",
ncs_read_pulse);
}
diff --git a/drivers/ide/at91_ide.c b/drivers/ide/at91_ide.c
index 000a78e..d9192e6 100644
--- a/drivers/ide/at91_ide.c
+++ b/drivers/ide/at91_ide.c
@@ -70,6 +70,7 @@ static void set_smc_timings(const u8 chipselect, const u16 cycle,
const u16 setup, const u16 pulse,
const u16 data_float, int use_iordy)
{
+ u16 ncs_rd_pulse;
unsigned long mode = AT91_SMC_READMODE | AT91_SMC_WRITEMODE |
AT91_SMC_BAT_SELECT;
@@ -81,19 +82,29 @@ static void set_smc_timings(const u8 chipselect, const u16 cycle,
if (data_float)
mode |= AT91_SMC_TDF_(data_float);
+ ncs_rd_pulse = cycle;
+ if (ncs_rd_pulse > 63) {
+ ncs_rd_pulse = 63;
+ pr_warn(DRV_NAME ": ncs_rd_pulse limited to maximal value %d\n",
+ ncs_rd_pulse);
+ }
+
at91_sys_write(AT91_SMC_MODE(chipselect), mode);
/* setup timings in SMC */
- at91_sys_write(AT91_SMC_SETUP(chipselect), AT91_SMC_NWESETUP_(setup) |
- AT91_SMC_NCS_WRSETUP_(0) |
- AT91_SMC_NRDSETUP_(setup) |
- AT91_SMC_NCS_RDSETUP_(0));
- at91_sys_write(AT91_SMC_PULSE(chipselect), AT91_SMC_NWEPULSE_(pulse) |
- AT91_SMC_NCS_WRPULSE_(cycle) |
- AT91_SMC_NRDPULSE_(pulse) |
- AT91_SMC_NCS_RDPULSE_(cycle));
- at91_sys_write(AT91_SMC_CYCLE(chipselect), AT91_SMC_NWECYCLE_(cycle) |
- AT91_SMC_NRDCYCLE_(cycle));
+ at91_sys_write(AT91_SMC_SETUP(chipselect),
+ AT91_SMC_NWESETUP_(setup) |
+ AT91_SMC_NCS_WRSETUP_(0) |
+ AT91_SMC_NRDSETUP_(setup) |
+ AT91_SMC_NCS_RDSETUP_(0));
+ at91_sys_write(AT91_SMC_PULSE(chipselect),
+ AT91_SMC_NWEPULSE_(pulse) |
+ AT91_SMC_NCS_WRPULSE_(ncs_rd_pulse) |
+ AT91_SMC_NRDPULSE_(pulse) |
+ AT91_SMC_NCS_RDPULSE_(ncs_rd_pulse));
+ at91_sys_write(AT91_SMC_CYCLE(chipselect),
+ AT91_SMC_NWECYCLE_(cycle) |
+ AT91_SMC_NRDCYCLE_(cycle));
}
static unsigned int calc_mck_cycles(unsigned int ns, unsigned int mck_hz)
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists