linux-kernel - Re: [PATCH] sa1100: Fix platform device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20101211205710.GB810@boggieman>
Date:	Sat, 11 Dec 2010 21:57:11 +0100
From:	Kristoffer Ericson <kristoffer.ericson@...il.com>
To:	Jochen Friedrich <jochen@...am.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sa1100: Fix platform device registration


Applies and makes sense, so

Acked-by: Kristoffer Ericson <kristoffer.ericson@...il.com>

On Sat, Dec 11, 2010 at 06:53:20PM +0100, Jochen Friedrich wrote:
> Since commit 7a5b4e16c880f8350d255dc188f81622905618c1, simpad devices don't
> boot anymore, since platform devices are registered too early. Fix by moving
> the registration from map_io to arch_initcall as done on other sa1100 boards.
> 
> Signed-off-by: Jochen Friedrich <jochen@...am.de>
> ---
>  arch/arm/mach-sa1100/simpad.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index 27692d0..cfb7607 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -166,9 +166,6 @@ static void __init simpad_map_io(void)
>  	PCFR = 0;
>  	PSDR = 0;
>  
> -	sa11x0_register_mtd(&simpad_flash_data, simpad_flash_resources,
> -			      ARRAY_SIZE(simpad_flash_resources));
> -	sa11x0_register_mcp(&simpad_mcp_data);
>  }
>  
>  static void simpad_power_off(void)
> @@ -216,6 +213,10 @@ static int __init simpad_init(void)
>  
>  	pm_power_off = simpad_power_off;
>  
> +	sa11x0_register_mtd(&simpad_flash_data, simpad_flash_resources,
> +			      ARRAY_SIZE(simpad_flash_resources));
> +	sa11x0_register_mcp(&simpad_mcp_data);
> +
>  	ret = platform_add_devices(devices, ARRAY_SIZE(devices));
>  	if(ret)
>  		printk(KERN_WARNING "simpad: Unable to register mq200 framebuffer device");
> -- 
> 1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/