linux-kernel - Re: [PATCH v2] ata: pata_at91.c bugfix for high master clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Dec 2010 16:49:22 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Igor Plyatov <plyatov@...il.com>
CC:	sshtylyov@...sta.com, jgarzik@...ox.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, geomatsi@...il.com,
	nicolas.ferre@...el.com, linux@...im.org.za,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	christian.glindkamp@...kit.de, ryan@...ewatersys.com,
	pgsellmann@...tner-elektronik.at
Subject: Re: [PATCH v2] ata: pata_at91.c bugfix for high master clock

Hello.

On 11-12-2010 23:37, Igor Plyatov wrote:

> The AT91SAM9 microcontrollers with master clock higher then 105 MHz
> and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This
> lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and driver
> does not detect ATA device.

> Signed-off-by: Igor Plyatov<plyatov@...il.com>
[...]

> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..a462405 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
[...]
> @@ -50,7 +52,7 @@ struct at91_ide_info {
>   };
>
>   static const struct ata_timing initial_timing =
> -	{XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> +	{XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0};

    BTW, you haven't described this in the changelog...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/