linux-kernel - Re: [PATCH 3/3] Staging: rt2860: include KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101213055637.GA1620@bicker>
Date:	Mon, 13 Dec 2010 08:56:37 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	L. Alberto Giménez <agimenez@...valve.es>,
	devel@...uxdriverproject.org, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk

On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote:
> On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote:
> > Fix checkpatch complains
> > diff --git a/drivers/staging/rt2860/common/ee_efuse.c b/drivers/staging/rt2860/common/ee_efuse.c
> []
> > @@ -281,8 +281,8 @@ int set_eFusedump_Proc(struct rt_rtmp_adapter *pAd, char *arg)
> >  
> >  		eFuseReadPhysical(pAd, &InBuf[0], 4, &InBuf[2], 2);
> >  		if (i % 4 == 0)
> > -			printk("\nBlock %x:", i / 8);
> > -		printk("%04x ", InBuf[2]);
> > +			printk(KERN_DEBUG "\nBlock %x:", i / 8);
> > +		printk(KERN_DEBUG "%04x ", InBuf[2]);
> >  	}
> >  	return TRUE;
> >  }
> 
> Not quite.  Use:
> 
> (before the for)
> 	printk(KERN_DEBUG "Block 0: ");
> 
> for(...)
> []
> 		if (i && i % 4 == 0) {
> 			printk(KERN_CONT "\n");
> 			printk(KERN_DEBUG "Block %x: ", i / 8);
> 		}
> 		printk(KERN_CONT " %04x", InBuf[2]);
> 	}
> 	printk(KERN_CONT "\n");
> 

This is dead code anyway.  Just remove the whole set_eFusedump_Proc()
function.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/