linux-kernel - Re: [PATCH 00/47] IO-less dirty throttling v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292239631.6803.186.camel@twins>
Date:	Mon, 13 Dec 2010 12:27:11 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Dave Chinner <david@...morbit.com>,
	Theodore Ts'o <tytso@....edu>,
	Chris Mason <chris.mason@...cle.com>,
	Mel Gorman <mel@....ul.ie>, Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Greg Thelen <gthelen@...gle.com>,
	Minchan Kim <minchan.kim@...il.com>,
	linux-mm <linux-mm@...ck.org>, linux-fsdevel@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/47] IO-less dirty throttling v3

On Mon, 2010-12-13 at 14:42 +0800, Wu Fengguang wrote:
> bdi dirty limit fixes
>         [PATCH 01/47] writeback: enabling gate limit for light dirtied bdi
>         [PATCH 02/47] writeback: safety margin for bdi stat error
> 
> v2 patches rebased onto the above two fixes
>         [PATCH 03/47] writeback: IO-less balance_dirty_pages()
>         [PATCH 04/47] writeback: consolidate variable names in balance_dirty_pages()
>         [PATCH 05/47] writeback: per-task rate limit on balance_dirty_pages()
>         [PATCH 06/47] writeback: prevent duplicate balance_dirty_pages_ratelimited() calls
>         [PATCH 07/47] writeback: account per-bdi accumulated written pages
>         [PATCH 08/47] writeback: bdi write bandwidth estimation
>         [PATCH 09/47] writeback: show bdi write bandwidth in debugfs
>         [PATCH 10/47] writeback: quit throttling when bdi dirty pages dropped low
>         [PATCH 11/47] writeback: reduce per-bdi dirty threshold ramp up time
>         [PATCH 12/47] writeback: make reasonable gap between the dirty/background thresholds
>         [PATCH 13/47] writeback: scale down max throttle bandwidth on concurrent dirtiers
>         [PATCH 14/47] writeback: add trace event for balance_dirty_pages()
>         [PATCH 15/47] writeback: make nr_to_write a per-file limit
> 
> trivial fixes for v2
>         [PATCH 16/47] writeback: make-nr_to_write-a-per-file-limit fix
>         [PATCH 17/47] writeback: do uninterruptible sleep in balance_dirty_pages()
>         [PATCH 18/47] writeback: move BDI_WRITTEN accounting into __bdi_writeout_inc()
>         [PATCH 19/47] writeback: fix increasement of nr_dirtied_pause
>         [PATCH 20/47] writeback: use do_div in bw calculation
>         [PATCH 21/47] writeback: prevent divide error on tiny HZ
>         [PATCH 22/47] writeback: prevent bandwidth calculation overflow
> 
> spinlock protected bandwidth estimation, as suggested by Peter
>         [PATCH 23/47] writeback: spinlock protected bdi bandwidth update
> 
> algorithm updates
>         [PATCH 24/47] writeback: increase pause time on concurrent dirtiers
>         [PATCH 25/47] writeback: make it easier to break from a dirty exceeded bdi
>         [PATCH 26/47] writeback: start background writeback earlier
>         [PATCH 27/47] writeback: user space think time compensation
>         [PATCH 28/47] writeback: bdi base throttle bandwidth
>         [PATCH 29/47] writeback: smoothed bdi dirty pages
>         [PATCH 30/47] writeback: adapt max balance pause time to memory size
>         [PATCH 31/47] writeback: increase min pause time on concurrent dirtiers 

I would think it would be easier for review to fold all this back into
sensible patches.

Reviewing is lots easier if the patches present logical steps. The
presented series will have us looking back and forth, review patch, find
bugs, then scan fwd to see if the bug has been solved, etc..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/