linux-kernel - Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292260699.6803.305.camel@twins>
Date:	Mon, 13 Dec 2010 18:18:19 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	"David S. Ahern" <daahern@...co.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header

On Mon, 2010-12-13 at 18:15 +0100, Frederic Weisbecker wrote:
> On Mon, Dec 13, 2010 at 06:11:29PM +0100, Peter Zijlstra wrote:
> > On Mon, 2010-12-13 at 18:09 +0100, Frederic Weisbecker wrote:
> > > 
> > > 
> > > Right, but Peter wanted us to get rid of these user events types.
> > 
> > Yes they suck.
> > 
> > > I guess we can't really do this as new perf tools must be able
> > > to support old perf files.
> > 
> > Preferably, yes, but I don't see why we can't break the data file format
> > if we've got good reasons to.
> 
> IMO we should prioritize the backward compatibility over some little code sanity.
> It's worth a very small range of values to reserve in the kernel and we are done.

Feh, excuses just grow more fungus on your code.

> > > So this should be the last one to add. Something like PERF_RECORD_GEN_EVT
> > > that has a field in its headers containing a sub-type which can be this
> > > wall clock but can also host about everything in the future.
> > > 
> > > This way we don't propagate more the possible overlap with the kernel. 
> > 
> > I don't see why we should add more, that's going the wrong direction.
> 
> This must be the last one.

No, the last one already happened, you cannot postpone the last one,
there will always be another excuse.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/