linux-kernel - Re: [PATCH 3/3] Staging: rt2860: include KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101213000106.GA2049@bart.evergreen.loc>
Date:	Mon, 13 Dec 2010 01:01:06 +0100
From:	L. Alberto Giménez <agimenez@...valve.es>
To:	Joe Perches <joe@...ches.com>
Cc:	devel@...uxdriverproject.org, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk

On Sun, Dec 12, 2010 at 11:46:09AM -0800, Joe Perches wrote:
> On Sun, 2010-12-12 at 20:25 +0100, L. Alberto Giménez wrote:
> > On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote:
> > > On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote:
> > > > diff --git a/drivers/staging/rt2860/pci_main_dev.c b/drivers/staging/rt2860/pci_main_dev.c
> > > > @@ -601,15 +600,15 @@ void hex_dump(char *str, unsigned char *pSrcBufVA, unsigned int SrcBufLen)
> > > >[...]
> > > This should use print_hex_dump
> > Ok, but I'll have to figure out how to translate the arguments without losing
> > the original developers intended format.
> 
> I think you can change the format without concern.
> 
> print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1,
> 	       pSrcBufVA, SrcBufLen, true);

Hi Joe,

If you don't mind, I will send this as a separate patch, since including it in
the KERN_* cleanup would clobber the patch and I'd prefer to make an standalone
patch for the hex_dump -> print_hex_dump modifications (many files in the source
do use the function).

Regards,
-- 
L. Alberto Giménez
JabberID agimenez@...ber.sysvalve.es
GnuPG key ID 0x3BAABDE1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/