linux-kernel - Re: [PATCH V2 -next] cs5535: fix printk format warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D06852B.8030409@oracle.com>
Date:	Mon, 13 Dec 2010 12:42:19 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Joe Perches <joe@...ches.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	akpm <akpm@...ux-foundation.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andres Salomon <dilinger@...labora.co.uk>
Subject: Re: [PATCH V2 -next] cs5535: fix printk format warnings

On 12/13/10 12:28, Joe Perches wrote:
> Use vsprintf extension %pR to format resource.
> 
> Original-patch-by: Randy Dunlap <randy.dunlap@...cle.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> ---
> 
>  drivers/gpio/cs5535-gpio.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/cs5535-gpio.c b/drivers/gpio/cs5535-gpio.c
> index b566fd5e..d7da7a1 100644
> --- a/drivers/gpio/cs5535-gpio.c
> +++ b/drivers/gpio/cs5535-gpio.c
> @@ -266,8 +266,7 @@ static int __devinit cs5535_gpio_probe(struct platform_device *pdev)
>  	cs5535_gpio_chip.pdev = pdev;
>  	spin_lock_init(&cs5535_gpio_chip.lock);
>  
> -	dev_info(&pdev->dev, "region 0x%x - 0x%x reserved\n",
> -			res->start, res->end);
> +	dev_info(&pdev->dev, "reserved resource region %pR\n", res);
>  
>  	/* mask out reserved pins */
>  	mask &= 0x1F7FFFFF;
> 
> 


OK.  How about similar patch for the other warnings:

drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/