linux-kernel - Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012132220220.26491@swampdragon.chaosbits.net>
Date:	Mon, 13 Dec 2010 22:22:11 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Hank Janssen <hjanssen@...rosoft.com>
cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, virtualization@...ts.osdl.org,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Ky Srinivasan <ksrinivasan@...ell.com>
Subject: Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc
 on initialize

On Mon, 13 Dec 2010, Hank Janssen wrote:

> Correct issue with not checking kmalloc return value.
> This fix now only uses one receive buffer for all hv_utils 
> channels, and will do only one kmalloc on init and will return
> with a -ENOMEM if kmalloc fails on initialize.
> 
> And properly clean up memory on failure.
> 
> Thanks to Evgeniy Polyakov <zbr@...emap.net> for pointing this out.
> And thanks to Jesper Juhl <jj@...osbits.net> and Ky Srinivasan 
> <ksrinivasan@...ell.com> for suggesting a better implementation of
> my original patch.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Signed-off-by: Hank Janssen <hjanssen@...rosoft.com>
> Cc: Evgeniy Polyakov <zbr@...emap.net>
> Cc: Jesper Juhl <jj@...osbits.net>
> Cc: Ky Srinivasan <ksrinivasan@...ell.com>
> 

I can't spot any problems with these changes now, so feel free to add
  Reviewed-by: Jesper Juhl <jj@...osbits.net>
if you like.


-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/