linux-kernel - Re: [PATCH] checkpatch.pl: ERROR: spaces required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201012132259.05317.toralf.foerster@gmx.de>
Date:	Mon, 13 Dec 2010 22:59:04 +0100
From:	Toralf Förster <toralf.foerster@....de>
To:	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl: ERROR: spaces required


Miguel Ojeda wrote at 19:49:43
> 2010/12/13 Toralf Förster <toralf.foerster@....de>:
> > Signed-off-by: Toralf Förster <toralf.foerster@....de>
> > ---
> >  kernel/acct.c |   20 ++++++++++----------
> >  1 files changed, 10 insertions(+), 10 deletions(-)
> > 
...
> > -       if (value==0) return 0;
> > -       while ((s64)value > 0){
> > +       if (value == 0) return 0;
> 
> Newline here. Doesn't checkpatch.pl complain? It is an old rule:
> 
> http://lxr.linux.no/linux+v2.6.36/Documentation/CodingStyle#L60
> 
I'd like to do only one thing at a time - not one file at a time.

-- 
MfG/Kind regards
Toralf Förster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/