linux-kernel - Re: [PATCH v2] Staging: rt2860: include KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101213221749.GA22029@kroah.com>
Date:	Mon, 13 Dec 2010 14:17:49 -0800
From:	Greg KH <greg@...ah.com>
To:	Joe Perches <joe@...ches.com>
Cc:	L. Alberto Giménez <agimenez@...valve.es>,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH v2] Staging: rt2860: include KERN_* in printk

On Mon, Dec 13, 2010 at 01:53:12PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 13:15 -0800, Greg KH wrote:
> > On Mon, Dec 13, 2010 at 09:24:30PM +0100, L. Alberto Giménez wrote:
> > > +#define DBGPRINT_ERR(fmt, args...) printk(KERN_ERR fmt, ##args)
> > > Recommended by Joe. I agree that it is cleaner and more compliant.
> > Not really, it should be replaced with dev_err() or some such universal
> > replacement.
> 
> It's used with and without access to a struct device.
> 
> The uses that have a struct device available should be
> dev_<foo> and with a struct net_device should be netdev_<foo>
> though that's a wider change.
> 
> It's also used in consecutive calls without newline where
> KERN_CONT should be used instead.
>  
> Greg, you replied to the list but not the sender.
> Please don't drop the sender.

If you look at the original message I responded to, the sender asked
_not_ to be included based on the headers of the message, so my email
client did the correct thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/