linux-kernel - Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101214004208.GA25538@xanatos>
Date:	Mon, 13 Dec 2010 16:42:08 -0800
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Andreas Mohr <andi@...as.de>
Cc:	Mark Brown <broonie@...ena.org.uk>,
	Matthias Schniedermeyer <ms@...d.de>,
	Luben Tuikov <ltuikov@...oo.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

On Mon, Dec 13, 2010 at 10:53:25PM +0100, Andreas Mohr wrote:
> I was just chilling down late in the evening by reading a short LKML 
> overview, and then inadvertently managed to hit this bomb shell ;)
> 
> > As uas has not been in a release-kernel, by definition, there is no 
> > impact either way. No regressions or anything else.
> 
> Since I've actually just been oldconfig'ing uas driver yesterday on a new 
> installation, I can relate to UAS kernel support being quite new 
> in its entirety.
> 
> If this is the case, then I'd also tend to believe the situation
> is very different from other more painful (since longstanding) driver conflicts
> (e.g. 8139, some raid drivers, and also e100 as witnessed by myself).
> 
> The author of UASP might want to adjust some of his writings
> (especially the more personal parts),
> however several parts of his criticism (e.g. no focus on code review)
> seem valid from my POV.

I think you may be missing some code review on the linux-usb mailing
list.  Luben posted his original patch to the uas.c driver there, but he
included behavior changes, code style modification, and variable
renaming in one giant patch.  It was very difficult to wade through, so
I asked him to break the changes into a series of patches (perhaps 18,
since he has 18 points?).

I did attempt to give a partial code review of Luben's original patches,
and he has yet to respond to any of my points:

http://marc.info/?l=linux-kernel&m=129021816023869&w=2

I also asked him to change a different patch for his driver, to move a
work-around into a better place:

http://marc.info/?l=linux-kernel&m=129192831709856&w=2

I have yet to see an updated patch set, only personal attacks.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/