linux-kernel - Re: [patch 2/3] add new macros to make percpu readmostly section correctly align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Dec 2010 10:58:01 +0100
From:	Tejun Heo <htejun@...il.com>
To:	Shaohua Li <shaohua.li@...el.com>
CC:	lkml <linux-kernel@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"sam@...nborg.org" <sam@...nborg.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: Re: [patch 2/3] add new macros to make percpu readmostly section
 correctly align

Hello,

On 12/14/2010 02:08 AM, Shaohua Li wrote:
> I don't understand what you mean. defining a cachine line size macro
> for all archs? There is such macro, but using it in vmlinux.ld.h
> always report error. There is some other defines which can't be
> included in a link script.

I haven't really looked through it but wouldn't it be possible to
ifdef it.  ie. if cacheline macro is available, align it to it;
otherwise, don't.  And, ultimately, the correct thing to do is making
it cacheline aligned on all archs.  There can be several different
ways to get there but it might just as well be making cacheline size
available in all archs first and then update the PERCPU macro.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/