linux-kernel - Re: [PATCH 9/9] xen/xen-pciback: Swap over to DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4D0750250200007800027C67@vpn.id2.novell.com>
Date:	Tue, 14 Dec 2010 10:08:21 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<xen-devel@...ts.xensource.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>
Cc:	"Stefano Stabellini" <stefano.stabellini@...citrix.com>,
	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	"Konrad Rzeszutek Wilk" <konrad@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/9] xen/xen-pciback: Swap over to
	 DEFINE_PCI_DEVICE_TABLE

>>> On 13.12.10 at 19:01, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> ---
>  drivers/xen/pciback/pci_stub.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/xen/pciback/pci_stub.c b/drivers/xen/pciback/pci_stub.c
> index c8f6f29..09dd60c 100644
> --- a/drivers/xen/pciback/pci_stub.c
> +++ b/drivers/xen/pciback/pci_stub.c
> @@ -497,7 +497,7 @@ static void pcistub_remove(struct pci_dev *dev)
>  	}
>  }
>  
> -static const struct pci_device_id pcistub_ids[] = {
> +DEFINE_PCI_DEVICE_TABLE(pcistub_ids) = {
>  	{
>  	 .vendor = PCI_ANY_ID,
>  	 .device = PCI_ANY_ID,


You shouldn't drop "static" here.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/