| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1292348880.7394.63.camel@nseg_linux_HP1.broadcom.com> Date: Tue, 14 Dec 2010 09:48:00 -0800 From: "Michael Chan" <mchan@...adcom.com> To: "Tejun Heo" <tj@...nel.org> cc: lkml <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one On Tue, 2010-12-14 at 08:09 -0800, Tejun Heo wrote: > Michael pointed out that bnx2_close() already cancels bp->reset_task > and thus it is guaranteed to be idle when bnx2_remove_one() is called. > Remove the unnecessary cancel_work_sync() in remove_one. > > Signed-off-by: Tejun Heo <tj@...nel.org> > Cc: Michael Chan <mchan@...adcom.com> Acked-by: Michael Chan <mchan@...adcom.com> > --- > drivers/net/bnx2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c > index 5c811f3..85fc2c8 100644 > --- a/drivers/net/bnx2.c > +++ b/drivers/net/bnx2.c > @@ -8393,8 +8393,6 @@ bnx2_remove_one(struct pci_dev *pdev) > struct net_device *dev = pci_get_drvdata(pdev); > struct bnx2 *bp = netdev_priv(dev); > > - cancel_work_sync(&bp->reset_task); > - > unregister_netdev(dev); > > if (bp->mips_firmware) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists