linux-kernel - Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors (whitespace cleanup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101214184253.GB1639@bicker>
Date:	Tue, 14 Dec 2010 21:42:57 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Toralf Förster <toralf.foerster@....de>
Cc:	tfransosi@...il.com, kernel-janitors@...r.kernel.org,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors
 (whitespace cleanup)

On Tue, Dec 14, 2010 at 05:58:08PM +0100, Toralf Förster wrote:
> nothing else
> 

This patch is not helpful.  I mean that in the sense that the code is
just as readable before and after.  :/  Please only send patches that
make the code better.

Checkpatch.pl is a good tool for staging but outside of staging you
should only use it for [check]ing [patch]es.  The problem is that
pointless churn clutters up the log and breaks git blame.  In staging
that's Ok.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/