linux-kernel - Re: [PATCH] fs/splice: Pull buf->ops->confirm() from splice_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D07CFC7.6050209@fusionio.com>
Date:	Tue, 14 Dec 2010 21:12:55 +0100
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:	Alexander Viro <viro@...iv.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Neil Brown <neilb@...e.de>
Subject: Re: [PATCH] fs/splice: Pull buf->ops->confirm() from  splice_from_pipe
 actors

On 2010-12-13 16:04, Michał Mirosław wrote:
> On Mon, Dec 13, 2010 at 02:38:19PM +0100, Jens Axboe wrote:
>> On 2010-12-12 22:23, Michał Mirosław wrote:
>>> This patch pulls calls to buf->ops->confirm() from all actors passed
>>> (also indirectly) to splice_from_pipe_feed().
>> Why? The point of ->confirm() is to ensure that the contents are
>> stable, otherwise the pages in the pipe could merely be in flight.
>> It's needed if you need to actually look at the data, rather than just
>> reference it.
> 
> I should have put this more clearly in the patch description:
> the ->confirm() call is moved to splice_from_pipe_feed(), so that every
> actor has its data guaranteed to be stable before it runs.

OK, that makes more sense. I'll queue it up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/