linux-kernel - Re: [PATCH] MTD: m25p80: add debugging trace in sst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D08C1C8.3090100@ru.mvista.com>
Date:	Wed, 15 Dec 2010 16:25:28 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] MTD: m25p80: add debugging trace in sst_write()

Hello.

On 15-12-2010 14:59, Nicolas Ferre wrote:

> Add a DEBUG(MTD_DEBUG_LEVEL2, ..) trace at beginning of sst_write() function as
> it is done in m25p80_write() function.

> Signed-off-by: Nicolas Ferre<nicolas.ferre@...el.com>
[...]

> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf5a002..e6b5707 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -482,6 +482,10 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
>   	size_t actual;
>   	int cmd_sz, ret;
>
> +	DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
> +			dev_name(&flash->spi->dev), __func__, "to",

    What's the point of printing "to" as variable? :-)

> +			(u32)to, len);
> +

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/