linux-kernel - Re: [PATCH v5 5/5] msm: add SMP support for msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101215160323.GA9937@n2100.arm.linux.org.uk>
Date:	Wed, 15 Dec 2010 16:03:23 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	David Brown <davidb@...eaurora.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Jeff Ohlstein <johlstei@...eaurora.org>,
	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Brian Swetland <swetland@...gle.com>,
	Dima Zavin <dima@...roid.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Steve Muckle <smuckle@...eaurora.org>
Subject: Re: [PATCH v5 5/5] msm: add SMP support for msm

On Wed, Dec 15, 2010 at 05:44:14AM -0800, David Brown wrote:
> On Wed, Dec 15, 2010 at 12:35:18PM +0000, Catalin Marinas wrote:
> > On 14 December 2010 04:50, Jeff Ohlstein <johlstei@...eaurora.org> wrote:
> > > +       outer_clean_range(__pa(&pen_release), __pa(&pen_release + 1));
> > > +       __asm__("sev");
> > > +       dsb();
> > 
> > What's the need for the dsb() here (one before SEV maybe)?
> > 
> > Also, do we need to add a "memory" clobber to the SEV asm, not sure
> > whether the compiler would try to reorder the code.
> 
> It doesn't seem to, but it seems to me that it would be allowed to,
> so, I would think the "memory" clobber should be there.

For each difference in the SMP and hotplug code from Realview (if it's
mostly identical to Realview), I'd personally like to see explainations
why it's necessary, either as comments in the code or at the very least
in the commit log.

As far as hotplug code goes, I wish folk would see what their hardware
can actually do with the secondary CPUs - can they take the CPU fully
offline and into a proper dormant state, and when they reawaken it, can
they wake it in the same manner as the CPU is brought online during
boot.

Realview doesn't do this because it can't reset the secondary CPUs
independent of the boot CPU, so the pattern it gives you should not
be followed unless your hardware is similarly restricted.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/