| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101215161213.GC9937@n2100.arm.linux.org.uk> Date: Wed, 15 Dec 2010 16:12:13 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Sergei Shtylyov <sshtylyov@...sta.com> Cc: Nicolas Ferre <nicolas.ferre@...el.com>, linux-mtd@...ts.infradead.org, dwmw2@...radead.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] MTD: m25p80: add debugging trace in sst_write() On Wed, Dec 15, 2010 at 04:25:28PM +0300, Sergei Shtylyov wrote: >> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n", >> + dev_name(&flash->spi->dev), __func__, "to", > > What's the point of printing "to" as variable? :-) One valid reason to do this is if you have several formatting strings all the same. GCC can merge identical strings together. So, if you have: "%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "to" "%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "from" "%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "foo" Then you end up with one long string and three short strings instead of "%s: %s to 0x%08x, len %zd", dev_name(), __func__ "%s: %s from 0x%08x, len %zd", dev_name(), __func__ "%s: %s foo 0x%08x, len %zd", dev_name(), __func__ which'd be three long strings. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists