linux-kernel - Re: [PATCH] include/linux: Add missing include / fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Dec 2010 10:31:41 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Peter Huewe <PeterHuewe@....de>
Cc:	Nick Piggin <npiggin@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include/linux: Add missing include / fix build failure

Hi Peter,

On Wed, 15 Dec 2010 22:04:18 +0100 Peter Huewe <PeterHuewe@....de> wrote:
>
> From: Peter Huewe <peterhuewe@....de>
> 
> This patch fixes a build failure[1-2] by adding the missing asm/memory.h
> include needed for arch_is_coherent().
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
> KernelVersion: linux-next-20101215
> Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)
> 
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
> [2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/
> 
> Error Message:
> In file included from include/linux/list_bl.h:5,
>                  from include/linux/rculist_bl.h:7,
>                  from include/linux/dcache.h:7,
>                  from include/linux/fs.h:381,
>                  from arch/arm/mm/mmap.c:4:
> include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
> include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'

All (or most) of the above information should be in the commit message
(so above the "Signed-off-by").

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped