linux-kernel - Re: [Patch 5/21] Rename compat versions of the reusable core generation routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101215080041.5c3ea5bc@suzukikp>
Date:	Wed, 15 Dec 2010 08:00:41 +0530
From:	"Suzuki K. Poulose" <suzuki@...ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Christoph Hellwig <hch@....de>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Daisuke HATAYAMA <d.hatayama@...fujitsu.com>,
	Andi Kleen <andi@...stfloor.org>,
	Roland McGrath <roland@...hat.com>,
	Amerigo Wang <amwang@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Patch 5/21] Rename compat versions of the reusable core
 generation routines

On Tue, 14 Dec 2010 16:57:08 +0100
Oleg Nesterov <oleg@...hat.com> wrote:

> On 12/14, Suzuki K. Poulose wrote:
> >
> > Rename the ELF class specific functions reusable for the application core dump 
> > infrastructure. The compat ELF class routines are prepended with compat_ .
> >
> > Signed-off-by: Suzuki K. Poulose <suzuki@...ibm.com>
> > ---
> >  fs/compat_binfmt_elf.c |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > Index: linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> > ===================================================================
> > --- linux-2.6.36-rc7.orig/fs/compat_binfmt_elf.c
> > +++ linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> > @@ -127,6 +127,13 @@ static void cputime_to_compat_timeval(co
> >  #define init_elf_binfmt		init_compat_elf_binfmt
> >  #define exit_elf_binfmt		exit_compat_elf_binfmt
> >
> > +/* Rename the functions that may be reused */
> > +#define fill_elf_header 	compat_fill_elf_header
> > +#define fill_psinfo		compat_fill_psinfo
> > +#define fill_prstatus		compat_fill_prstatus
> > +#define fill_extnum_info	compat_fill_extnum_info
> > +#define fill_auxv_note		compat_fill_auxv_note
> 
> Can't undestand.... Afaics, the kernel can't be compiled
> with this change until the next patches actually implement
> compat_xxx ?

The compat_binfmt_elf.c shares the actual ELF handling code from binfmt_elf.c (by 
#includ ing it). This patch renames the functions so that we can later export it. 
The "#include binfmt_elf.c" comes later in the compat_binfmt_elf.c. So we are fine.
> 
> This is not bisect friendly.
> 
> Oleg.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/