linux-kernel - Re: [PATCH] ext4: fix typo in ext4_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D0A16F9.9000503@nokia.com>
Date:	Thu, 16 Dec 2010 16:41:13 +0300
From:	Roman Borisov <ext-roman.borisov@...ia.com>
To:	ext Eric Sandeen <sandeen@...hat.com>, jack@...e.cz
CC:	Aaro Koskinen <aaro.koskinen@...ia.com>, tytso@....edu,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	ext-phil.2.carmody@...ia.com
Subject: Re: [PATCH] ext4: fix typo in ext4_find_entry()

On 12/08/2010 08:53 PM, ext Eric Sandeen wrote:
> On 12/08/2010 10:33 AM, Aaro Koskinen wrote:
>> There should be a check for NUL character instead of '0'.
>>
>> Reported-by: Phil Carmody<ext-phil.2.carmody@...ia.com>
>> Signed-off-by: Aaro Koskinen<aaro.koskinen@...ia.com>
>> ---
>>   fs/ext4/namei.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>> index 92203b8..dc40e75 100644
>> --- a/fs/ext4/namei.c
>> +++ b/fs/ext4/namei.c
>> @@ -872,7 +872,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
>>   	if (namelen>  EXT4_NAME_LEN)
>>   		return NULL;
>>   	if ((namelen<= 2)&&  (name[0] == '.')&&
>> -	    (name[1] == '.' || name[1] == '0')) {
>> +	    (name[1] == '.' || name[1] == '\0')) {
>>   		/*
>>   		 * "." or ".." will only be in the first block
>>   		 * NFS may look up ".."; "." should be handled by the VFS
>
> Yep, as it was reviewed on the list when originally sent, oops! ;)
>
> -Eric

Hi,

the same fix should be done for ext3 patch which is planned to be in 
mainline: http://www.spinics.net/lists/linux-ext4/msg21215.html

Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/