[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101216150757.GA5841@redhat.com>
Date: Thu, 16 Dec 2010 16:07:57 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Mike Galbraith <efault@....de>
Cc: linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
hpa@...or.com, mingo@...hat.com, mathieu.desnoyers@...icios.com,
a.p.zijlstra@...llo.nl, torvalds@...ux-foundation.org,
pjt@...gle.com, markus@...ppelsdorf.de, tglx@...utronix.de,
mingo@...e.hu
Subject: Re: [tip:sched/core] sched: Add 'autogroup' scheduling feature:
automated per session task groups
On 12/16, Mike Galbraith wrote:
>
> I'd also have to disable interrupts though,
Even irq_disable can't help, I think.
> so may as well just lock it.
this also looks simpler.
> I didn't do the -ESRCH or no display bit. As far as autogroup is
> concerned, if you couldn't lock, it's history, so belongs to init.
Agreed. I considered this option too, but I was worried about
sched_group_set_shares(root).
However, as you pointed out,
> sched_group_set_shares() does the right thing, says no to changing the
> root task group's shares.
Aha, I see, thanks.
I believe the patch is correct and closes the hole.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists