linux-kernel - Re: [Patch 18/21] Generate the data sections for ELF Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D0975ED.7010803@redhat.com>
Date:	Thu, 16 Dec 2010 10:14:05 +0800
From:	Cong Wang <amwang@...hat.com>
To:	"Suzuki K. Poulose" <suzuki@...ibm.com>
CC:	linux-kernel@...r.kernel.org,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Christoph Hellwig <hch@....de>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Daisuke HATAYAMA <d.hatayama@...fujitsu.com>,
	Andi Kleen <andi@...stfloor.org>,
	Roland McGrath <roland@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Patch 18/21] Generate the data sections for ELF Core

于 2010年12月15日 20:46, Suzuki K. Poulose 写道:
> On Wed, 15 Dec 2010 15:19:54 +0800
> Cong Wang<amwang@...hat.com>  wrote:
>
>> 于 2010年12月14日 18:22, Suzuki K. Poulose 写道:
...
>>> +
>>> +		off_t offset = *fpos - elf_hdr->e_shoff;
>>
>> Are you sure it is 'off_t' not 'loff_t'?
>>
>
> You are right. I will change it
>>> +		size_t shdrsz = sizeof(struct elf_shdr) - offset;
>>> +

If you use loff_t, then this line needs to be changed too.
size_t could be shorter than loff_t.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/