linux-kernel - Re: [PATCH] leds: leds-pca9532 cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101216173726.GC28364@core.coreip.homeip.net>
Date:	Thu, 16 Dec 2010 09:37:26 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Riku Voipio <riku.voipio@....fi>,
	Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] leds: leds-pca9532 cleanups

On Thu, Dec 16, 2010 at 05:05:53PM +0800, Axel Lin wrote:
> >From 6244111ba78a6768ded3fedf8967b6bc891fa757 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@...il.com>
> Date: Thu, 16 Dec 2010 15:41:55 +0800
> Subject: [PATCH] leds: leds-pca9532 cleanups
> 
> This patch includes below fixes:
> 1. Remove unneeded input_free_device() after input_unregister_device().
> 2. Use "while (--i >= 0)" instead of "if (i > 0) for (i = i - 1; i >= 0; i--)"
>    for reclaim resources in pca9532_configure() error path.
>    I think this change improves readability.

The whole chunk should be in a separate function, like

void pca9532_destroy_devices(struct pca9532_data *data, int n_devs);

That can be called from both pca9532_configure() and pca9532_remove().

For the input change:

	Acked-by: Dmitry Torokhov <dtor@...l.ru>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/