linux-kernel - Re: [PATCH 5/6] speedtch: don't abuse struct delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101216213005.GA5781@kroah.com>
Date:	Thu, 16 Dec 2010 13:30:05 -0800
From:	Greg KH <greg@...ah.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Duncan Sands <duncan.sands@...e.fr>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 5/6] speedtch: don't abuse struct delayed_work

On Sun, Dec 12, 2010 at 05:48:18PM +0100, Tejun Heo wrote:
> speedtch directly uses the internal timer and work members of a struct
> delayed_work.  Use a separate work item and timer instead.
> 
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Duncan Sands <duncan.sands@...e.fr>
> Cc: linux-usb@...r.kernel.org
> ---
> This is part of a series to remove flush_scheduled_work() usage to
> prepare for deprecation of flush_scheduled_work().  Patches in this
> series are self contained and mostly straight-forward.
> 
> Please feel free to take it into the appropriate tree, or just ack it.
> In the latter case, I'll merge the patch through the workqueue tree
> during the next merge window.

You forgot to add a "Signed-off-by:" on these patches, so I can't take
them in my tree :(

But feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

to both 5/6 and 6/6 of this series and take them through your tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/