linux-kernel - Re: [PATCH v5 5/5] msm: add SMP support for msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101216214420.GX9937@n2100.arm.linux.org.uk>
Date:	Thu, 16 Dec 2010 21:44:20 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jeff Ohlstein <johlstei@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Brian Swetland <swetland@...gle.com>,
	Dima Zavin <dima@...roid.com>,
	Arve Hj�nnev�g <arve@...roid.com>,
	Bryan Huntsman <bryanh@...eaurora.org>
Subject: Re: [PATCH v5 5/5] msm: add SMP support for msm

On Wed, Dec 15, 2010 at 10:54:16PM -0800, Jeff Ohlstein wrote:
> +void __cpuinit platform_secondary_init(unsigned int cpu)
> +{
> +	/* Configure edge-triggered PPIs */
> +	writel(GIC_PPI_EDGE_MASK, MSM_QGIC_DIST_BASE + GIC_DIST_CONFIG + 4);

At some point we should really clean this up so we don't have code
writing directly to the GIC registers like this.

> +static __init void prepare_cold_cpu(unsigned int cpu)
> +{
> +	int ret;
> +	ret = scm_set_boot_addr((void *)
> +				virt_to_phys(msm_secondary_startup),

It seems wrong to cast a physical address to a pointer - physical
addresses should not be pointer-like.  Can it stay as an integer?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/