linux-kernel - Re: [PATCH v3] cpuidle: extend cpuidle and menu governor to handle dynamic states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101216063322.GA18025@ywang-moblin2.bj.intel.com>
Date:	Thu, 16 Dec 2010 14:33:22 +0800
From:	Yong Wang <yong.y.wang@...ux.intel.com>
To:	Ai Li <aili@...eaurora.org>
Cc:	akpm@...ux-foundation.org, dwalker@...eaurora.org,
	arjan@...ux.intel.com, mingo@...e.hu, shemminger@...tta.com,
	czoccolo@...il.com, len.brown@...el.com, h.peter.anvin@...el.com,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH v3] cpuidle: extend cpuidle and menu governor to handle
	dynamic states

On Fri, Jul 30, 2010 at 09:49:11AM -0600, Ai Li wrote:
> On some SoC chips, HW resources may be in use during any particular idle
> period.  As a consequence, the cpuidle states that the SoC is safe to
> enter can change from idle period to idle period.  In addition, the
> latency and threshold of each cpuidle state can vary, depending on the
> operating condition when the CPU becomes idle, e.g. the current cpu
> frequency, the current state of the HW blocks, etc.
> 
> cpuidle core and the menu governor, in the current form, are geared
> towards cpuidle states that are static, i.e. the availabiltiy of the
> states, their latencies, their thresholds are non-changing during run
> time.  cpuidle does not provide any hook that cpuidle drivers can use
> to adjust those values on the fly for the current idle period before the
> menu governor selects the target cpuidle state.
> 
> This patch extends cpuidle core and the menu governor to handle states
> that are dynamic.  There are three additions in the patch and the patch
> maintains backwards-compatibility with existing cpuidle drivers.
> 
> 1) add prepare() to struct cpuidle_device.  A cpuidle driver can hook
> into the callback and cpuidle will call prepare() before calling the
> governor's select function.  The callback gives the cpuidle driver a
> chance to update the dynamic information of the cpuidle states for the
> current idle period, e.g. state availability, latencies, thresholds,
> power values, etc.
> 

Could you please point me to some sample code regarding how to use this
'prepare' callback?

> +
> +	/*
> +	 * Call the device's prepare function before calling the
> +	 * governor's select function.  ->prepare gives the device's
> +	 * cpuidle driver a chance to update any dynamic information
> +	 * of its cpuidle states for the current idle period, e.g.
> +	 * state availability, latencies, residencies, etc.
> +	 */
> +	if (dev->prepare)
> +		dev->prepare(dev);
> +
>  	/* ask the governor for the next state */
>  	next_state = cpuidle_curr_governor->select(dev);

In terms of dynamic states, what if situation changes between the
'prepare' callback and the selected state is actually entered? Like a
particular state makes sense when 'prepare' is called but does not make
sense any more when cpuidle actually tries to enter that state?

Thanks
-Yong

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/