| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Dec 2010 13:18:55 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: Mike Snitzer <snitzer@...hat.com> cc: dm-devel@...hat.com, linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org Subject: Re: [PATCH][rfc] md: Close mem leak in userspace_ctr() On Tue, 14 Dec 2010, Mike Snitzer wrote: > On Mon, Dec 13 2010 at 6:40pm -0500, > Jesper Juhl <jj@...osbits.net> wrote: > > > Hi, > > > > There's a small memory leak in > > drivers/md/dm-log-userspace-base.c::userspace_ctr(). > > > > The call to build_constructor_string() dynamically allocates memory for > > its last argument, but we do not always clean up that allocated memory. > > I'm not seeing a leak. > > The kfree() that you've added to the build_constructor_string() failure > path isn't needed because build_constructor_string() only returns error > if the kzalloc() failed. > Hmm, that's true, assuming that there are no bugs (and never will be) in strlen() or sprintf() that result in 'str_size' becoming negative the code is safe. That's probably a safe assumption ;-) Sorry about the noise. -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists