linux-kernel - Re: [PATCH] USB: g_serial: Allow to override the default VID/PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101217000202.GA29844@kroah.com>
Date:	Thu, 16 Dec 2010 16:02:02 -0800
From:	Greg KH <greg@...ah.com>
To:	Jef Driesen <jefdriesen@...enet.be>
Cc:	Robert Lukassen <Robert.Lukassen@...tom.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: g_serial: Allow to override the default VID/PID

On Wed, Dec 15, 2010 at 08:57:47AM +0100, Jef Driesen wrote:
> On 06/12/10 09:09, Robert Lukassen wrote:
> >Yes, providing access to those module parameters was the original goal. I
> >agree that my patch should be reverted and I'll try to come up with a method
> >of accessing these values without violating the information hiding principles
> >too much. I don't like accessing globals.
> 
> Do I have to take any action to make sure the original commit [1] gets reverted?
> 
> [1] 1ab83238740ff1e1773d5c13ecac43c60cf4aec4

It's now reverted.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/