linux-kernel - Re: [PATCH] mmc/sdhci: Enable bus-width test for JMicron controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101217035806.GB19673@void.printf.net>
Date:	Fri, 17 Dec 2010 03:58:06 +0000
From:	Chris Ball <cjb@...top.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Philip Rakity <prakity@...vell.com>,
	Aries Lee <arieslee@...cron.com>,
	zhangfei gao <zhangfei.gao@...il.com>, wuqm@...vell.com,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc/sdhci: Enable bus-width test for JMicron
	controllers

Hi Takashi,

On Thu, Dec 16, 2010 at 05:54:14PM +0100, Takashi Iwai wrote:
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
> 
> This is a patch to be applied after
>   "mmc: Test bus-width for old MMC devices (v2)"
> 
> and a replacement for the previous "mmc: Enable bus-width tests on
> SDHCI host" patch.  Instead of enabling all for sdhci, this one turns
> on the feature only for JMicron, just to be safer.
> 
> 
>  drivers/mmc/host/sdhci-pci.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
> index d2638ff..0dc905b 100644
> --- a/drivers/mmc/host/sdhci-pci.c
> +++ b/drivers/mmc/host/sdhci-pci.c
> @@ -381,6 +381,8 @@ static int jmicron_probe_slot(struct sdhci_pci_slot *slot)
>  	    slot->chip->pdev->device == PCI_DEVICE_ID_JMICRON_JMB388_ESD)
>  		jmicron_enable_mmc(slot->host, 1);
>  
> +	slot->host->mmc->caps |= MMC_CAP_BUS_WIDTH_TEST;
> +
>  	return 0;
>  }
>  

Thanks, pushed to mmc-next.

(Do others on the list agree that bus-width testing should be
whitelisted per-host like this?)

-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/