linux-kernel - Re: [PATCH] Input: introduce device information ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101218201313.GA1675@polaris.bitmath.org>
Date:	Sat, 18 Dec 2010 21:13:14 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Ping Cheng <pinglinux@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Chris Bagwell <chris@...bagwell.com>,
	Chase Douglas <chase.douglas@...onical.com>,
	Peter Hutterer <peter.hutterer@...-t.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: introduce device information ioctl

On Fri, Dec 17, 2010 at 11:24:44AM -0800, Ping Cheng wrote:
> On Thu, Dec 16, 2010 at 12:30 PM, Henrik Rydberg <rydberg@...omail.se> wrote:
> > Today, userspace sets up an input device based on the data it emits.
> > This is not always enough; a tablet and a touchscreen may emit exactly
> > the same data, for instance, but the former should be set up with a
> > pointer whereas the latter does not need to. Recently, a new type of
> > touchpad has emerged where the buttons are under the pad, which
> > changes handling logic without changing the emitted data. This patch
> > introduces a new ioctl, EVIOCGPROP, which enables user access to a set
> > of device properties useful during setup. The properties are given as
> > a bitmap in the same fashion as the event types, and are also made
> > available via sysfs.
> >
> > Signed-off-by: Henrik Rydberg <rydberg@...omail.se>
> 
> Reviewed-by: Ping Cheng <pingc@...om.com>
> 
> I wonder if we need to mention this new ioctl somewhere under
> Documentation/input or not. INPUT_PROP_SEMI_MT could add useful
> information for multi-touch-protocol.txt. The others could play a role
> in Chase's new Documentation/input/evdev-codes.txt.

Thank you, Ping - I added an acked-by to the last version by mistake,
instead of a reviewed-by. Is that alright with you? And yes, I think the
properties need to be documented somewhere.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/