| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101218090714.GA436@polaris.bitmath.org> Date: Sat, 18 Dec 2010 10:07:14 +0100 From: "Henrik Rydberg" <rydberg@...omail.se> To: Guenter Roeck <guenter.roeck@...csson.com> Cc: Matthew Garrett <mjg@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "lm-sensors@...sensors.org" <lm-sensors@...sensors.org> Subject: Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices On Fri, Dec 17, 2010 at 08:23:21PM -0800, Guenter Roeck wrote: > On Fri, Dec 17, 2010 at 05:24:20PM -0500, Matthew Garrett wrote: > > The AppleSMC device is described in ACPI, including a list of its resources. > > We should use those rather than hardcoding the ports. A side-effect is that > > we can then remove the DMI matching, since there's a unique identifier to > > indicate that the machine has one of these devices. > > > > Signed-off-by: Matthew Garrett <mjg@...hat.com> > > You added a whitespace error, and kfree() is safe and doesn't need a check. > I fixed those, so no need to resubmit. If Henrik gives his Ack we are ready to go. Thanks, I will give it some testing before doing so. Matthew, did you test this under EFI boot? Also, NOTIFICATION_KEY does not seem to be used anywhere. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists