linux-kernel - [PATCH] Add readpages support for block devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1292632073-6196-1-git-send-email-willy@linux.intel.com>
Date:	Fri, 17 Dec 2010 19:27:53 -0500
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Jens Axboe <jaxboe@...ionio.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Cc:	Shane Michael Matthews <shane.matthews@...el.com>,
	Matthew Wilcox <willy@...ux.intel.com>
Subject: [PATCH] Add readpages support for block devices

From: Shane Michael Matthews <shane.matthews@...el.com>

Using mpage_readpages instead of multiple calls to blkdev_readpage reduces
the CPU utilisation by 35% when using dd to clone a drive.

Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
Signed-off-by: Shane Michael Matthews <shane.matthews@...el.com>
---
 fs/block_dev.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 4230252..55cf932 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -318,6 +318,12 @@ static int blkdev_readpage(struct file * file, struct page * page)
 	return block_read_full_page(page, blkdev_get_block);
 }
 
+static int blkdev_readpages(struct file *file, struct address_space *mapping,
+			struct list_head *pages, unsigned nr_pages)
+{
+	return mpage_readpages(mapping, pages, nr_pages, blkdev_get_block);
+}
+
 static int blkdev_write_begin(struct file *file, struct address_space *mapping,
 			loff_t pos, unsigned len, unsigned flags,
 			struct page **pagep, void **fsdata)
@@ -1634,6 +1640,7 @@ static int blkdev_releasepage(struct page *page, gfp_t wait)
 
 static const struct address_space_operations def_blk_aops = {
 	.readpage	= blkdev_readpage,
+	.readpages	= blkdev_readpages,
 	.writepage	= blkdev_writepage,
 	.sync_page	= block_sync_page,
 	.write_begin	= blkdev_write_begin,
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/