linux-kernel - RE: [PATCH] leds-lp5521: modify the way of setting led device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F45880696056844FA6A73F415B568C6953716AA735@EXDCVYMBSTM006.EQ1STM.local>
Date:	Sun, 19 Dec 2010 11:57:56 +0100
From:	Arun MURTHY <arun.murthy@...ricsson.com>
To:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Cc:	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"samu.p.onkalo@...ia.com" <samu.p.onkalo@...ia.com>
Subject: RE: [PATCH] leds-lp5521: modify the way of setting led device name

Hi Andrew,
	Since Richard is not active in the community, can you please push this
patch through your mm tree.

Thanks and Regards,
Arun R Murthy
--------------

> -----Original Message-----
> From: Onkalo Samu [mailto:samu.p.onkalo@...ia.com]
> Sent: Thursday, December 16, 2010 6:37 PM
> To: Arun MURTHY
> Cc: akpm@...ux-foundation.org; rpurdie@...ys.net; Linus WALLEIJ; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH] leds-lp5521: modify the way of setting led device
> name
> 
> On Wed, 2010-12-15 at 17:25 +0530, ext Arun Murthy wrote:
> > Currently the led device name is fetched from the device_type in
> > I2C_BOARD_INFO which comes from the platform data. This name is in
> turn
> > used to create an entry in sysfs.
> >
> > If there exists two or more lp5521 on a particular platform, the
> > device_type in I2C_BOARD_INFO has to be the same, else lp5521 driver
> > probe wont be called and if used so, results in run time warning
> "cannot
> > create sysfs with same name" and hence a failure.
> >
> > The name that is used to create sysfs entry is to be passed by the
> > struct led_platform_data. Hence adding an element of type const char
> *
> > and change in lp5521 driver to use this name in creating the led
> device
> > if present else use the name obtained by I2C_BOARD_INFO.
> >
> > Signed-off-by: Arun Murthy <arun.murthy@...ricsson.com>
> 
> Looks ok.
> 
> I'll make similar patch for lp5523 at some point.
> 
> Acked-by: Samu Onkalo <samu.p.onkalo@...ia.com>