lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 09:28:38 +0800 From: Shaohua Li <shaohua.li@...el.com> To: Tejun Heo <htejun@...il.com> Cc: Sam Ravnborg <sam@...nborg.org>, lkml <linux-kernel@...r.kernel.org>, "hpa@...or.com" <hpa@...or.com>, Andrew Morton <akpm@...ux-foundation.org>, "eric.dumazet@...il.com" <eric.dumazet@...il.com> Subject: Re: [patch 2/3] add new macros to make percpu readmostly section correctly align On Thu, 2010-12-16 at 17:50 +0800, Tejun Heo wrote: > Hello, Shaohua. > > On 12/16/2010 06:56 AM, Shaohua Li wrote: > >>>>> -#include <asm-generic/vmlinux.lds.h> > >>>>> #include <asm/asm-offsets.h> > >>>>> #include <asm/thread_info.h> > >>>>> #include <asm/page_types.h> > >>>>> #include <asm/cache.h> > >>>>> +#include <asm-generic/vmlinux.lds.h> > >>>>> #include <asm/boot.h> > >>>> > >>>> Why do we need this chunk? > >>> the cache size is defined in cache.h, so I need move vmlinux.lds.h after > >>> cache.h > >> > >> The right fix is to move the inclusion of cache.h to > >> asm-generic/vmlinux.lds.h. A quick audit only found sparc that > >> failed to guard non assembler stuff. > > > > with this, we need check every arch, at least doing a compile. I'm > > afraid I can't, sorry. > > Not being able to cross build every arch is okay but you at least need > to make an effort to make things easily applicable to other archs and > avoid adding subtle ugliness like the above. Please at least try to > look at other arch codes and see how things can be made to work across > different archs. Setting up cross compilers for the major archs, for > example, sparc, power and ia64 isn't that difficult either. This still needs I fix every arch, for example, as Sam pointed out, spark build will fail. I really have the bandwidth and capability to do this. Increment changes are always preferred. My original patch is trying to follow increment changes way. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists