lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 10:53:22 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Minchan Kim <minchan.kim@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, Hugh Dickins <hughd@...gle.com> Subject: Re: [RFC 1/5] drop page reference on remove_from_page_cache On Sat, 18 Dec 2010 02:13:36 +0900 Minchan Kim <minchan.kim@...il.com> wrote: > Now we add page reference on add_to_page_cache but doesn't drop it > in remove_from_page_cache. Such asymmetric makes confusing about > page reference so that caller should notice it and comment why they > release page reference. It's not good API. > > Long time ago, Hugh tried it[1] but gave up of reason which > reiser4's drop_page had to unlock the page between removing it from > page cache and doing the page_cache_release. But now the situation is > changed. I think at least things in current mainline doesn't have any > obstacles. The problem is fs or somethings out of mainline. > If it has done such thing like reiser4, this patch could be a problem. > > Do anyone know the such things? Do we care about things out of mainline? > > Note : > The comment of remove_from_page_cache make by copy & paste & s/swap/page/ > from delete_from_swap_cache. > > [1] http://lkml.org/lkml/2004/10/24/140 > > Cc: Hugh Dickins <hughd@...gle.com> > Cc: linux-mm@...ck.org > Signed-off-by: Minchan Kim <minchan.kim@...il.com> I like this. Reviewd-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists