linux-kernel - Re: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292856704.4500.249.camel@zakaz.uk.xensource.com>
Date:	Mon, 20 Dec 2010 14:51:44 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Daniel Kiper <dkiper@...-space.pl>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"andi.kleen@...el.com" <andi.kleen@...el.com>,
	"haicheng.li@...ux.intel.com" <haicheng.li@...ux.intel.com>,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"Dan Magenheimer" <dan.magenheimer@...cle.com>,
	"v.tolstov@...fip.ru" <v.tolstov@...fip.ru>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon
 features and fixes

On Mon, 2010-12-20 at 13:47 +0000, Daniel Kiper wrote:
> Features and fixes:
>   - HVM mode is supported now,
>   - migration from mod_timer() to schedule_delayed_work(),
>   - removal of driver_pages (I do not have seen any
>     references to it),
>   - protect before CPU exhaust by event/x process during
>     errors by adding some delays in scheduling next event,
>   - some other minor fixes.

Each of those bullets should be a separate patch (or several if
appropriate). I didn't review most of the rest because it mixed so much
stuff together but a couple of minor things jumped out.

> -static void scrub_page(struct page *page)
> +static inline void scrub_page(struct page *page)

Is there some reason we need to override the compiler's decision here?
There is some discussion of the (over)use of inline in CodingStyle.

>  static struct attribute_group balloon_info_group = {
>         .name = "info",
> -       .attrs = balloon_info_attrs,
> +       .attrs = balloon_info_attrs
>  };
> 
>  static struct sysdev_class balloon_sysdev_class = {
> -       .name = BALLOON_CLASS_NAME,
> +       .name = BALLOON_CLASS_NAME
>  };

I don't think there is anything wrong with the existing style here.

Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/