lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Dec 2010 19:07:59 -0700 From: Matthew Wilcox <matthew@....cx> To: "Nicholas A. Bellinger" <nab@...ux-iscsi.org> Cc: linux-scsi <linux-scsi@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, James Bottomley <James.Bottomley@...e.de>, Jeff Garzik <jeff@...zik.org>, Christoph Hellwig <hch@....de>, FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, Hannes Reinecke <hare@...e.de>, Mike Christie <michaelc@...wisc.edu> Subject: Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally On Sun, Dec 19, 2010 at 05:22:06PM -0800, Nicholas A. Bellinger wrote: > Actually sorry, Mike Christie did already make a clarification on this > subject here: > > http://marc.info/?l=linux-scsi&m=129010439421506&w=2 > > I had originally thought the same that session->lock should be using > some flavour of spin_lock_irq*() as well, but apparently this is not the > case for libiscsi. Right, so it seems. "the session lock is just locked in softirqs/timers" means that it does need to be the _bh() version of spin_lock though. I'm actually not sure ... is it safe to use the _bh versions in BH context? I think it is because the preempt count is nested, unlike the _irq variants of spinlocks. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists