linux-kernel - Re: [PATCH] [libata] pata_cs5536: Add support for non-X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=pKc6KcJeXhdBbqDJ45Gmfy0UVwgCucK6KLUz1@mail.gmail.com>
Date:	Tue, 21 Dec 2010 01:17:47 +0800
From:	wu zhangjin <wuzhangjin@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	"Martin K. Petersen" <mkp@....net>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, Zhang Le <r0bertz@...too.org>,
	Chen Jie <chenj@...ote.com>
Subject: Re: [PATCH] [libata] pata_cs5536: Add support for non-X86_32 platforms

Hi, Sergei

On Mon, Dec 20, 2010 at 7:19 PM, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
> Hello.
>
> On 19-12-2010 17:32, Wu Zhangjin wrote:
>
>> pata_cs5536 does work on the other platforms(e.g. Loongson, a MIPS
>> variant), so, remove the dependency of X86_32 and fix the building
>> errors under the other platforms via only reserving the X86_32 specific
>> parts for X86_32.
>
>> pata_amd also supports cs5536 IDE controller, but this one saves about
>> 33k for the compressed kernel image(vmlinuz for MIPS).
>
>> Signed-off-by: Zhang Le <r0bertz@...too.org>
>> Signed-off-by: Chen Jie <chenj@...ote.com>
>> Signed-off-by: Wu Zhangjin <wuzhangjin@...il.com>
>
> [...]
>
>> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
>> index 21ee23f..643488b 100644
>> --- a/drivers/ata/pata_cs5536.c
>> +++ b/drivers/ata/pata_cs5536.c
>> @@ -37,7 +37,17 @@
>>  #include<linux/delay.h>
>>  #include<linux/libata.h>
>>  #include<scsi/scsi_host.h>
>> +
>> +#ifdef CONFIG_X86_32
>>  #include<asm/msr.h>
>> +static int use_msr;
>> +module_param_named(msr, use_msr, int, 0644);
>> +MODULE_PARM_DESC(msr, "Force using MSR to configure IDE function
>> (Default: 0)");
>> +#else
>> +#define rdmsr(x, y, z) do { } while (0)
>> +#define wrmsr(x, y, z) do { } while (0)
>> +#define use_msr 0
>> +#endif
>>
>>  #define DRV_NAME      "pata_cs5536"
>>  #define DRV_VERSION   "0.0.7"
>
>   I think you should increment the driver version too.
>

Will use 0.0.8 in the next revision of this patch.

With the version incrementation, can I get your "Acked-by:"?

Thanks & Regards,
Wu Zhangjin

> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/