lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 23:10:34 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: "Andreas.Eversberg" <Andreas.Eversberg@...satel.de> cc: Karsten Keil <isdn@...ux-pingi.de>, "David S. Miller" <davem@...emloft.net>, Julia Lawall <julia@...u.dk>, Tejun Heo <tj@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: AW: [PATCH] ISDN cmx: Avoid potential NULL deref in dsp_cmx_send_member() and shrink code size. On Mon, 20 Dec 2010, Andreas.Eversberg wrote: > hi jesper, > > thanx for finding the bug. i think the right solution to solve the problem would be: > > if (dsp->conf && dsp->conf->software && dsp->conf->hardware) > tx_data_only = 1; > -> if (dsp->echo.software && dsp->echo.hardware) > tx_data_only = 1; > > this is how it looks in the 'socket' branch of mISDN git respository. it has been fixed already. but i cannot tell in which commit. my current head is this commit: > commit 45a51eed1c554a4891b48b88c270f4f95bd21df0 > I'm not familiar enough with the code to determine if my fix or the one you propose is the right one. My fix is functionally equivalent to what was there before (minus the NULL deref), yours is not. I'll let someone more knowledgeable about the ISDN code determine what is the right fix. > what branch do you use? > I'm working against Linus' kernel as of today. -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists