lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 20 Dec 2010 15:16:49 -0800
From:	Daniel Walker <dwalker@...eaurora.org>
To:	davidb@...eaurora.org
Cc:	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Daniel Walker <dwalker@...eaurora.org>
Subject: [PATCH 3/5] mmc: msm: fix msmsdcc_disable_clocks spinlock protection

The function msmsdcc_disable_clocks needs to be called with
the host lock held.

Signed-off-by: Daniel Walker <dwalker@...eaurora.org>
---
 drivers/mmc/host/msm_sdcc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 01bb684..c64a659 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -261,10 +261,10 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,
 			host->curr.cmd = NULL;
 			mrq->data->bytes_xfered = host->curr.data_xfered;
 
-			spin_unlock_irqrestore(&host->lock, flags);
-
 			msmsdcc_disable_clocks(host, 1);
 
+			spin_unlock_irqrestore(&host->lock, flags);
+
 			mmc_request_done(host->mmc, mrq);
 			return;
 		} else
-- 
1.7.0.4

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists