lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 09:10:41 +0300 From: Dan Carpenter <error27@...il.com> To: Paul Turner <pjt@...gle.com> Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org Subject: [smatch] sched_fair: check after dereference Hi Paul, In linux-next e33078baa4 "sched: Fix update_cfs_load() synchronization" introduced a dereference before the check for NULL. I don't know the code well enough to say if it's a bug or if the check can be removed. kernel/sched_fair.c +728 update_cfs_load(6) warn: variable dereferenced before check 'cfs_rq' 722 static void update_cfs_load(struct cfs_rq *cfs_rq, int global_update) 723 { 724 u64 period = sysctl_sched_shares_window; 725 u64 now, delta; 726 unsigned long load = cfs_rq->load.weight; ^^^^^^^^^^^^^^^^^^^ 727 728 if (!cfs_rq) ^^^^^^ 729 return; Can you take a look? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists