lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Dec 2010 19:19:10 -0500 From: Jeff Garzik <jeff@...zik.org> To: Matthew Wilcox <matthew@....cx> CC: "Nicholas A. Bellinger" <nab@...ux-iscsi.org>, linux-scsi <linux-scsi@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, James Bottomley <James.Bottomley@...e.de>, Christoph Hellwig <hch@....de>, FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, Hannes Reinecke <hare@...e.de>, Mike Christie <michaelc@...wisc.edu>, Mike Anderson <andmike@...ux.vnet.ibm.com>, Tejun Heo <tj@...nel.org>, Vasu Dev <vasu.dev@...ux.intel.com>, Tim Chen <tim.c.chen@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>, Ravi Anand <ravi.anand@...gic.com>, Andrew Vasquez <andrew.vasquez@...gic.com>, Joe Eykholt <jeykholt@...co.com>, James Smart <james.smart@...lex.com>, Douglas Gilbert <dgilbert@...erlog.com>, adam radford <aradford@...il.com>, Kashyap Desai <Kashyap.Desai@....com>, MPTFusionLinux <DL-MPTFusionLinux@....com> Subject: Re: [PATCH 07/12] qla2xxx: Convert to host_lock less w/ interrupts disabled externally On 12/19/2010 06:11 PM, Matthew Wilcox wrote: > I'm not sure this is the right direction to go. Now that Jeff's done > the pushdown and put in the compatibility macros, I don't think it makes > sense to do another partial transition on each driver. Much better to > take our time, analyse each driver thoroughly, and kill the DEF_SCSI_QCMD > in each driver without introducing IRQ_DISABLE_SCSI_QCMD. Agreed... DEF_SCSI_QCMD was intended, as you note, to encourage a piecemeal, in-depth approach to cleaning up the rest of the drivers. Hopefully DEF_SCSI_QCMD removal means someone actually figured out [or already knew] the locking for a driver, and created the most appropriate patch, rather than another half-step. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists